Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds two NVIDIA CUDA package dependencies (nvidia-cuda-runtime and nvidia-curand) to the project's dependency list to support GPU-accelerated tractography functionality.
Changes:
- Added
nvidia-cuda-runtimedependency for CUDA runtime support - Added
nvidia-curanddependency for CUDA random number generation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
21
| "nvidia-cuda-runtime", | ||
| "nvidia-curand", | ||
| "cuda-python", | ||
| "cuda-core", | ||
| "cuda-cccl" |
There was a problem hiding this comment.
The added dependencies lack version constraints. Consider adding version pins or at minimum version ranges to ensure reproducible builds and avoid potential compatibility issues. For example: nvidia-cuda-runtime>=12.0,<13.0 and nvidia-curand>=12.0,<13.0.
Suggested change
| "nvidia-cuda-runtime", | |
| "nvidia-curand", | |
| "cuda-python", | |
| "cuda-core", | |
| "cuda-cccl" | |
| "nvidia-cuda-runtime>=12.0,<13.0", | |
| "nvidia-curand>=12.0,<13.0", | |
| "cuda-python>=12.0,<13.0", | |
| "cuda-core>=12.0,<13.0", | |
| "cuda-cccl>=12.0,<13.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.